PMD Results

The following document contains the results of PMD.

Summary

FilesErrors
1569

Files

FilesViolations
org/apache/portals/bridges/jsf/AbstractAttributeMap.java 3
org/apache/portals/bridges/jsf/ApplicationMap.java 3
org/apache/portals/bridges/jsf/FacesPortlet.java 13
org/apache/portals/bridges/jsf/InitParameterMap.java 3
org/apache/portals/bridges/jsf/PortletExternalContextImpl.java 5
org/apache/portals/bridges/jsf/PortletFacesContextImpl.java 6
org/apache/portals/bridges/jsf/PortletUIViewRoot.java 1
org/apache/portals/bridges/jsf/RequestMap.java 4
org/apache/portals/bridges/jsf/RequestParameterMap.java 3
org/apache/portals/bridges/jsf/RequestParameterValuesMap.java 3
org/apache/portals/bridges/jsf/ServletCookieMap.java 3
org/apache/portals/bridges/jsf/ServletExternalContextImpl.java 7
org/apache/portals/bridges/jsf/ServletFacesContextImpl.java 6
org/apache/portals/bridges/jsf/ServletRequestMap.java 2
org/apache/portals/bridges/jsf/SessionMap.java 7

org/apache/portals/bridges/jsf/AbstractAttributeMap.java

ViolationLine
Avoid if (x != y) ..; else ..; 100
Avoid if (x != y) ..; else ..; 124
Avoid if (x != y) ..; else ..; 180

org/apache/portals/bridges/jsf/ApplicationMap.java

ViolationLine
No need to import a type that's in the same package 23
Avoid if (x != y) ..; else ..; 63
Avoid if (x != y) ..; else ..; 101

org/apache/portals/bridges/jsf/FacesPortlet.java

ViolationLine
Avoid unused imports such as 'RenderKitFactory' 35
The class 'FacesPortlet' has a Cyclomatic Complexity of 4 (Highest = 11). 61
Avoid unused private fields such as 'application' 165
Avoid really long methods. 452
The method 'process' has a Cyclomatic Complexity of 11. 452
Avoid unused local variables such as 'defaultView' 458
Avoid unused local variables such as 'actionResponse' 501
Avoid if (x != y) ..; else ..; 582
Avoid if (x != y) ..; else ..; 593
Avoid reassigning parameters such as 'defaultView' 616
Avoid if (x != y) ..; else ..; 628
Avoid if (x != y) ..; else ..; 644
Avoid if (x != y) ..; else ..; 675

org/apache/portals/bridges/jsf/InitParameterMap.java

ViolationLine
No need to import a type that's in the same package 23
Avoid if (x != y) ..; else ..; 63
Avoid if (x != y) ..; else ..; 95

org/apache/portals/bridges/jsf/PortletExternalContextImpl.java

ViolationLine
Avoid unused private fields such as 'requestCookieMap' 91
Avoid unused private fields such as 'requestPathInfo' 97
Avoid unused private fields such as 'requestServletPath' 100
Avoid if (x != y) ..; else ..; 403
Avoid if (x != y) ..; else ..; 436

org/apache/portals/bridges/jsf/PortletFacesContextImpl.java

ViolationLine
Avoid unused imports such as 'ActionRequest' 37
Avoid calls to overridable methods during construction 109
Avoid if (x != y) ..; else ..; 197
Avoid using if statements without curly braces 273
Avoid using if statements without curly braces 278
Avoid if (x != y) ..; else ..; 398

org/apache/portals/bridges/jsf/PortletUIViewRoot.java

ViolationLine
Avoid using if statements without curly braces 60

org/apache/portals/bridges/jsf/RequestMap.java

ViolationLine
Avoid unused imports such as 'PortletContext' 21
No need to import a type that's in the same package 24
Avoid if (x != y) ..; else ..; 61
Avoid if (x != y) ..; else ..; 98

org/apache/portals/bridges/jsf/RequestParameterMap.java

ViolationLine
No need to import a type that's in the same package 23
Avoid if (x != y) ..; else ..; 60
Avoid if (x != y) ..; else ..; 91

org/apache/portals/bridges/jsf/RequestParameterValuesMap.java

ViolationLine
No need to import a type that's in the same package 23
Avoid if (x != y) ..; else ..; 60
Avoid if (x != y) ..; else ..; 91

org/apache/portals/bridges/jsf/ServletCookieMap.java

ViolationLine
Avoid using if statements without curly braces 47
Avoid using if statements without curly braces 67
Avoid using if statements without curly braces 100

org/apache/portals/bridges/jsf/ServletExternalContextImpl.java

ViolationLine
Deeply nested if..then statements are hard to read 111
Avoid using if statements without curly braces 125
Avoid if (x != y) ..; else ..; 139
Avoid using if statements without curly braces 155
Avoid using if statements without curly braces 159
The same String literal appears 15 times in this file; the first occurrence is on line 187 187
Avoid if (x != y) ..; else ..; 418

org/apache/portals/bridges/jsf/ServletFacesContextImpl.java

ViolationLine
Avoid calls to overridable methods during construction 61
The same String literal appears 18 times in this file; the first occurrence is on line 80 80
Avoid if (x != y) ..; else ..; 98
Avoid using if statements without curly braces 140
Avoid using if statements without curly braces 144
Avoid if (x != y) ..; else ..; 259

org/apache/portals/bridges/jsf/ServletRequestMap.java

ViolationLine
Avoid if (x != y) ..; else ..; 57
Avoid if (x != y) ..; else ..; 94

org/apache/portals/bridges/jsf/SessionMap.java

ViolationLine
No need to import a type that's in the same package 24
No need to import a type that's in the same package 25
Avoid if (x != y) ..; else ..; 65
Avoid calling toString() on String objects; this is unnecessary 68
An empty statement (semicolon) not part of a loop 96
Avoid if (x != y) ..; else ..; 109
An empty statement (semicolon) not part of a loop 112