PMD Results

The following document contains the results of PMD.

Summary

FilesErrors
2689

Files

FilesViolations
org/apache/portals/bridges/struts/PortletRequestProcessor.java 2
org/apache/portals/bridges/struts/PortletServlet.java 10
org/apache/portals/bridges/struts/PortletServletConfigImpl.java 1
org/apache/portals/bridges/struts/PortletServletContextImpl.java 4
org/apache/portals/bridges/struts/PortletServletRequestDispatcher.java 3
org/apache/portals/bridges/struts/PortletServletRequestWrapper.java 6
org/apache/portals/bridges/struts/PortletServletResponseWrapper.java 5
org/apache/portals/bridges/struts/PortletTilesRequestProcessor.java 2
org/apache/portals/bridges/struts/StrutsPortlet.java 27
org/apache/portals/bridges/struts/StrutsPortletURL.java 6
org/apache/portals/bridges/struts/config/AbstractConfigComponent.java 1
org/apache/portals/bridges/struts/config/PortletURLTypes.java 2
org/apache/portals/bridges/struts/config/RenderContextAttributes.java 2
org/apache/portals/bridges/struts/config/StrutsPortletConfig.java 1
org/apache/portals/bridges/struts/taglib/ELFormTag.java 1
org/apache/portals/bridges/struts/taglib/ELImageTag.java 1
org/apache/portals/bridges/struts/taglib/ELImgTag.java 1
org/apache/portals/bridges/struts/taglib/ELLinkTag.java 1
org/apache/portals/bridges/struts/taglib/ELRewriteTag.java 1
org/apache/portals/bridges/struts/taglib/FormTag.java 1
org/apache/portals/bridges/struts/taglib/ImageTag.java 1
org/apache/portals/bridges/struts/taglib/ImgTag.java 1
org/apache/portals/bridges/struts/taglib/LinkTag.java 1
org/apache/portals/bridges/struts/taglib/RewriteTag.java 1
org/apache/portals/bridges/struts/taglib/ScriptTag.java 3
org/apache/portals/bridges/struts/taglib/TagsSupport.java 4

org/apache/portals/bridges/struts/PortletRequestProcessor.java

ViolationLine
Avoid reassigning parameters such as 'response' 41
Avoid using 'if...else' statements without curly braces 64

org/apache/portals/bridges/struts/PortletServlet.java

ViolationLine
The class 'PortletServlet' has a Cyclomatic Complexity of 4 (Highest = 12). 45
The method 'performActionRenderRequest' has a Cyclomatic Complexity of 12. 125
Avoid if (x != y) ..; else ..; 146
Deeply nested if..then statements are hard to read 147
Deeply nested if..then statements are hard to read 155
Avoid using if statements without curly braces 161
Avoid using if statements without curly braces 163
Avoid using if statements without curly braces 166
Avoid using 'if...else' statements without curly braces 173
Avoid using 'if...else' statements without curly braces 176

org/apache/portals/bridges/struts/PortletServletConfigImpl.java

ViolationLine
Avoid using if statements without curly braces 49

org/apache/portals/bridges/struts/PortletServletContextImpl.java

ViolationLine
Avoid using 'if...else' statements without curly braces 56
Avoid using 'if...else' statements without curly braces 58
Avoid using if statements without curly braces 83
Avoid using if statements without curly braces 95

org/apache/portals/bridges/struts/PortletServletRequestDispatcher.java

ViolationLine
Avoid unused formal parameters such as 'include' 55
Avoid using if statements without curly braces 86
Deeply nested if..then statements are hard to read 86

org/apache/portals/bridges/struts/PortletServletRequestWrapper.java

ViolationLine
Avoid unused private fields such as 'log' 36
Avoid if (x != y) ..; else ..; 88
Avoid using 'if...else' statements without curly braces 94
Avoid if (x != y) ..; else ..; 103
Avoid using 'if...else' statements without curly braces 104
Avoid using 'if...else' statements without curly braces 106

org/apache/portals/bridges/struts/PortletServletResponseWrapper.java

ViolationLine
Avoid unused private fields such as 'log' 36
Avoid using 'if...else' statements without curly braces 51
Avoid using 'if...else' statements without curly braces 53
Avoid using 'if...else' statements without curly braces 62
Avoid using 'if...else' statements without curly braces 64

org/apache/portals/bridges/struts/PortletTilesRequestProcessor.java

ViolationLine
Avoid reassigning parameters such as 'response' 41
Avoid using 'if...else' statements without curly braces 64

org/apache/portals/bridges/struts/StrutsPortlet.java

ViolationLine
The class 'StrutsPortlet' has a Cyclomatic Complexity of 3 (Highest = 32). 52
The method 'init' has a Cyclomatic Complexity of 13. 127
Avoid using if statements without curly braces 131
Avoid using 'if...else' statements without curly braces 148
Avoid using if statements without curly braces 152
Avoid using if statements without curly braces 158
Avoid using if statements without curly braces 180
Avoid using if statements without curly braces 182
Avoid using if statements without curly braces 184
Avoid using if statements without curly braces 186
Avoid really long methods. 309
The method 'processRequest' has a Cyclomatic Complexity of 32. 309
Avoid using if statements without curly braces 375
Avoid using if statements without curly braces 431
Avoid using if statements without curly braces 436
Avoid if (x != y) ..; else ..; 442
Avoid using if statements without curly braces 449
Avoid empty catch blocks 460
Avoid if (x != y) ..; else ..; 464
Avoid using if statements without curly braces 467
Avoid using if statements without curly braces 495
Avoid using if statements without curly braces 502
Avoid using if statements without curly braces 513
Avoid using if statements without curly braces 524
Avoid using if statements without curly braces 527
Avoid using if statements without curly braces 533
Avoid using 'for' statements without curly braces 543

org/apache/portals/bridges/struts/StrutsPortletURL.java

ViolationLine
Avoid reassigning parameters such as 'pageURL' 46
Avoid using 'if...else' statements without curly braces 52
Avoid using 'if...else' statements without curly braces 54
Avoid using if statements without curly braces 59
Avoid using if statements without curly braces 66
All methods are static. Consider using Singleton instead. Alternatively, you could add a private constructor to silence this warning. 86

org/apache/portals/bridges/struts/config/AbstractConfigComponent.java

ViolationLine
Avoid using if statements without curly braces 48

org/apache/portals/bridges/struts/config/PortletURLTypes.java

ViolationLine
Ensure you override both equals() and hashCode() 70
Avoid if (x != y) ..; else ..; 72

org/apache/portals/bridges/struts/config/RenderContextAttributes.java

ViolationLine
The class 'RenderContextAttributes' has a Cyclomatic Complexity of 3 (Highest = 13). 30
The method 'saveAttributes' has a Cyclomatic Complexity of 13. 194

org/apache/portals/bridges/struts/config/StrutsPortletConfig.java

ViolationLine
Avoid empty catch blocks 64

org/apache/portals/bridges/struts/taglib/ELFormTag.java

ViolationLine
Avoid unused imports such as 'ServletRequest' 19

org/apache/portals/bridges/struts/taglib/ELImageTag.java

ViolationLine
Avoid unused imports such as 'ServletRequest' 19

org/apache/portals/bridges/struts/taglib/ELImgTag.java

ViolationLine
Avoid unused imports such as 'ServletRequest' 19

org/apache/portals/bridges/struts/taglib/ELLinkTag.java

ViolationLine
Avoid unused imports such as 'ServletRequest' 19

org/apache/portals/bridges/struts/taglib/ELRewriteTag.java

ViolationLine
Avoid unused imports such as 'ServletRequest' 19

org/apache/portals/bridges/struts/taglib/FormTag.java

ViolationLine
Avoid unused imports such as 'ServletRequest' 19

org/apache/portals/bridges/struts/taglib/ImageTag.java

ViolationLine
Avoid unused imports such as 'ServletRequest' 19

org/apache/portals/bridges/struts/taglib/ImgTag.java

ViolationLine
Avoid unused imports such as 'ServletRequest' 19

org/apache/portals/bridges/struts/taglib/LinkTag.java

ViolationLine
Avoid unused imports such as 'ServletRequest' 19

org/apache/portals/bridges/struts/taglib/RewriteTag.java

ViolationLine
Avoid unused imports such as 'ServletRequest' 19

org/apache/portals/bridges/struts/taglib/ScriptTag.java

ViolationLine
Avoid if (x != y) ..; else ..; 77
Avoid using 'if...else' statements without curly braces 78
Avoid using 'if...else' statements without curly braces 80

org/apache/portals/bridges/struts/taglib/TagsSupport.java

ViolationLine
Avoid reassigning parameters such as 'url' 51
Avoid reassigning parameters such as 'type' 108
Avoid reassigning parameters such as 'url' 108
Avoid reassigning parameters such as 'formStartElement' 147